ci: fix regression test paths #4996
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
The "Performance Regression Test" workflow was not marked required, so c012d98 was merged despite breaking the test. This fixes the test.
I also removed the "paths-ignore". It was preventing the test from running and verifying this fix. We definitely need the regression test to run when we modify the regression test-- how else will we know whether changes to the test itself break the test itself?
Call-outs:
As a follow-up, we need to mark "Performance Regression Test" as required. If it's not marked required because of flakiness, we need to address that flakiness. If it just doesn't provide particularly useful information, we should either remove it or just make it always pass if it successfully runs (even if it detects a problem).
Testing:
Testing this is a little tricky. The test uses both the PR version of the code and the main branch version, but the main branch version is currently broken. Unless we revert the broken commit, this PR will need to be merged with the test still failing.
I think the best I can do to prove this fix works is to prove that it works if you remove the steps that require the main branch. See this PR on my fork: lrstewart#57, with a passing stripped down version of the test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.