Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update CRT test ubuntu version to ubuntu24 #4964

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

boquan-fang
Copy link
Contributor

Description of changes:

Our CI is blocked by CRT. Currently, CRT-CPP can't properly prebuild AWSLC on Ubuntu 18. Hence, I tried to update the Ubuntu version to 24, and it successfully build AWSLC on a newer platform. I have already created an issue for the CRT team to ask questions: awslabs/aws-crt-cpp#691.

Call-outs:

  • Update the CRT test's Ubuntu version to Ubuntu 24 is a step that we want to take to upgrade our CI to use newer versions of Ubuntu in general. Migrate CI to Ubuntu 24 #4537

Testing:

This PR will be tested by the CI. I have already verified that CRT test will pass on this PR.
Refer to the result of s2nGeneralBatch for further testing details.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Dec 9, 2024
@boquan-fang boquan-fang marked this pull request as ready for review December 9, 2024 23:43
@boquan-fang boquan-fang requested a review from dougch as a code owner December 9, 2024 23:43
@boquan-fang boquan-fang requested a review from camshaft December 9, 2024 23:43
@boquan-fang boquan-fang merged commit a004f2b into aws:main Dec 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants