refactor: add a s2n_libcrypto_is_openssl() helper function #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-libcrypto_openssl
branch
2 times, most recently
from
5dfe535 to
92f4729
Compare
toidiu
force-pushed
the
ak-libcrypto_openssl
branch
from
92f4729 to
f2d3a14
Compare
lrstewart
reviewed
Nov 25, 2024
crypto/s2n_libcrypto.c
Outdated
Comment on lines
118
to
119
| * Note: This check needs to be updated if s2n-tls adds support for a new | ||
| * libcrypto. |
There was a problem hiding this comment.
I wonder if we actually could write a test to enforce this. Like add some string matching to https://github.com/aws/s2n-tls/blob/main/tests/unit/s2n_build_test.c.
There was a problem hiding this comment.
Awesome suggestion. I added a test for supported libcrytpo 6be1cfc
jmayclin
reviewed
Nov 26, 2024
lrstewart
reviewed
Nov 27, 2024
toidiu
changed the title
jmayclin
approved these changes
Dec 2, 2024
toidiu
changed the title
lrstewart
approved these changes
Dec 3, 2024
toidiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds/fixes documentation, fixes a test and introduces the helper function
s2n_libcrypto_is_openssl().This fn will be used in #4878 to gate the use of custom random to only openssl.
Callout:
We have to detect openssl by detecting the absence of other libcrypto. I have added a comment explaining why this is necessary.
Testing:
Added a new unit test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.