Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(s2n-tls-hyper): Add localhost http tests #4838

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

goatgoose
Copy link
Contributor

Resolved issues:

Resolves #4631

Description of changes:

This PR adds a way to test s2n-tls-hyper over localhost by using the hyper server to echo HTTP requests back to the s2n-tls hyper client. A few tests were added which make use of the echo framework.

Call-outs:

Now that s2n-tls-hyper is tested locally, the web_client test was removed to reduce flakiness caused by relying on an external endpoint.

Testing:

All tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@goatgoose goatgoose marked this pull request as ready for review October 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove external HTTP request from hyper crate tests
2 participants