Update PQ code to be generic over EVP_KEM API's #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Oct 1, 2024
lrstewart
reviewed
Oct 1, 2024
lrstewart
reviewed
Oct 1, 2024
lrstewart
approved these changes
Oct 1, 2024
alexw91
changed the title
alexw91
changed the title
geedo0
approved these changes
Oct 2, 2024
goatgoose
approved these changes
Oct 2, 2024
goatgoose
approved these changes
Oct 2, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
None
Description of changes:
Part 1 in a multi-part series to add ML-KEM support to s2n. This PR updates s2n's PQ code to be generic over the availability of the EVP KEM API's already being used instead of being specific to Kyber. This change will make it easier to add ML-KEM in a future PR.
Call-outs:
Cleaned up a few redundant usages of
s2n_pq_is_enabled()ands2n_libcrypto_supports_evp_kem()to simplify the s2n code.s2n_pq_is_enabled()is just an alias fors2n_libcrypto_supports_evp_kem()now (since s2n no longer has an internal implementation of Kyber). Code paths that checked if these functions had different values have been deleted.Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.