ci: Emit CloudWatch metrics from rust benchmarks #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
bench-metrics
branch
from
437382f to
145f4d0
Compare
goatgoose
force-pushed
the
bench-metrics
branch
from
145f4d0 to
e78ee5b
Compare
jmayclin
approved these changes
Sep 4, 2024
dougch
approved these changes
Sep 4, 2024
goatgoose
force-pushed
the
bench-metrics
branch
from
c6ba676 to
b16a9fe
Compare
dougch
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds a new Github action which runs the s2n-tls criterion benchmarks and publishes the results to CloudWatch. The CloudWatch metrics are published from a script that parses the output of criterion to obtain the benchmarking results.
Call-outs:
The Github action is set to run on merges to main and on a schedule. Running when merging to main ensures that each s2n-tls commit can be observed for performance changes. Running on a schedule ensures that changes to any other benchmarking target can be observed if an s2n-tls commit hasn't been merged in a while.
Testing:
A commit that ran on pull requests was added for testing: b16a9fe
The Github action output from this commit can be viewed here: https://github.com/aws/s2n-tls/actions/runs/10780428029/job/29896166564
The metrics produced from this commit can be viewed in CloudWatch: https://us-west-2.console.aws.amazon.com/cloudwatch/home?region=us-west-2#dashboards/dashboard/s2n-tls-perf?start=PT168H&end=null
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.