tests: add JA4 pcap tests #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add JA4 to the existing pcap tests.
Ubuntu-22 (ubuntu-latest) only has tshark 3.6, which doesn't have JA4 support. Ubuntu-24 has tshark 4.2, which DOES have JA4 support. So I switched the pcap test job to use ubuntu-24. Ubuntu-24 has been available as a public beta since May.
I made ja4 support an optional feature so that the pcap tests can still run in older environments without JA4 (like my own testing host >_>).
Callouts
If folks don't like using the beta ubuntu-24 image, I might be able to use MacOS. I didn't check the github image, but my laptop had tshark 4.2.
Testing:
Is a new test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.