Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable blinding #4562
feat: Configurable blinding #4562
Changes from 11 commits
898adc0
ef748f0
59a7cd6
d7f984d
cc4e4e5
edf41ca
94b3466
e50032d
6409f7b
177f5f6
ea7a220
a988cc2
4068b89
3d2b188
2b60922
f907acb
7d728ae
8f01074
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does recovering a byte mean here? I would have assumed the calculation would be in terms of number of samples required to observe a timing difference. Or is this description specifically related to lucky 13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the number of samples required to distinguish the timing distributions from a correctly guessed byte versus incorrectly guessed bytes. In lucky13 in particular, if you've correctly guessed the last byte of padding, the timing distribution that is created from sampling that byte would be slightly different than the timing distributions of an incorrect byte.
😮💨 So hard to describe this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think I could add something to make this paragraph more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think it makes sense. I guess I just wasn't sure if this same description could be applied to all sidechannels or just lucky 13. Like, could there be a timing difference that could be exploited without the goal of differentiating a correct byte from an incorrect byte? If so, then it might help to clarify that this example of recovering bytes is specific to lucky 13.