Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bindings): fix client hello doc tests #4495

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented Apr 10, 2024

Description of changes:

cargo test currently fails on mainline bindings because the doc tests fail. This is because some of the configuring functionality was refactored in #4474 .

This PR

  • adds CI for default cargo test
  • moves doc test in client_hello.rs to a feature-gated module
  • modifies doc test in connection.rs to only use non-gated methods.

Testing:

More CI was added to prevent a regression.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Apr 10, 2024
- gate first doc test behind a configure module
- modify other doc tests to use default features
@jmayclin jmayclin marked this pull request as ready for review April 10, 2024 01:43
@jmayclin jmayclin changed the title docs(bindings): fix doctest import path docs(bindings): fix client hello doc tests Apr 10, 2024
Copy link
Contributor

@maddeleine maddeleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@jmayclin jmayclin enabled auto-merge (squash) April 15, 2024 18:16
@jmayclin jmayclin merged commit 152d035 into aws:main Apr 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants