-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add s2n_prelude.h to consolidate defines #4465
Open
camshaft
wants to merge
4
commits into
aws:main
Choose a base branch
from
camshaft:camshaft/prelude
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
#pragma once | ||
|
||
/* This captures Darwin specialities. This is the only APPLE flavor we care about. | ||
* Here we also capture various required feature test macros. | ||
*/ | ||
#if defined(__APPLE__) | ||
typedef struct _opaque_pthread_once_t __darwin_pthread_once_t; | ||
typedef __darwin_pthread_once_t pthread_once_t; | ||
#define _DARWIN_C_SOURCE | ||
#elif defined(__FreeBSD__) || defined(__OpenBSD__) | ||
/* FreeBSD requires POSIX compatibility off for its syscalls (enables __BSD_VISIBLE) | ||
* Without the below line, <sys/mman.h> cannot be imported (it requires __BSD_VISIBLE) */ | ||
#undef _POSIX_C_SOURCE | ||
#elif !defined(_GNU_SOURCE) | ||
#define _GNU_SOURCE | ||
#endif | ||
|
||
#include <sys/mman.h> | ||
|
||
/* Not always defined for Darwin */ | ||
#if !defined(MAP_ANONYMOUS) | ||
#define MAP_ANONYMOUS MAP_ANON | ||
#endif | ||
|
||
#include <pthread.h> | ||
#include <stdlib.h> | ||
#include <sys/types.h> | ||
#include <unistd.h> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
#pragma once | ||
|
||
/* Let modules know that the prelude was included */ | ||
#define _S2N_PRELUDE_INCLUDED | ||
|
||
/* Define the POSIX API we are targeting */ | ||
#ifndef _POSIX_C_SOURCE | ||
#define _POSIX_C_SOURCE 200809L | ||
#endif | ||
|
||
/** | ||
* If we're building in release mode make sure _FORTIFY_SOURCE is set | ||
* See: https://www.gnu.org/software/libc/manual/html_node/Source-Fortification.html | ||
* https://man7.org/linux/man-pages/man7/feature_test_macros.7.html | ||
* | ||
* NOTE: _FORTIFY_SOURCE can only be set when optimizations are enabled. | ||
* https://sourceware.org/git/?p=glibc.git;a=commit;f=include/features.h;h=05c2c9618f583ea4acd69b3fe5ae2a2922dd2ddc | ||
*/ | ||
#if !defined(_FORTIFY_SOURCE) && defined(S2N_BUILD_RELEASE) | ||
#define _FORTIFY_SOURCE 2 | ||
#endif | ||
|
||
#if ((__GNUC__ >= 4) || defined(__clang__)) && defined(S2N_EXPORTS) | ||
/** | ||
* Marks a function as belonging to the public s2n API. | ||
* | ||
* See: https://gcc.gnu.org/wiki/Visibility | ||
*/ | ||
#define S2N_API __attribute__((visibility("default"))) | ||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if we accidentally remove this "include"? Does it fail loudly?
And as discussed offline, maybe an assert or a test would give a nice clear failure.