Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Most of the ktls code is hit by the standard valgrind and asan tests, but our self-talk tests only run in the specific ktls CI build. For thoroughness, we should probably have at least asan run against the self-talk tests.
While testing, I also found some related issues:
Testing:
I manually kicked off s2nGeneralBatch. You can see the new "ktlsASAN" build passing. It's output says that AddressSanitizer is being configured:
I created a branch with a memory leak that only the ktls build will catch. I manually kicked off a build, and ktlsASAN failed as expected:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.