Add different parameters for memory benching #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 25, 2023 22:33
tinzh
force-pushed
the
memory-parameters
branch
2 times, most recently
from
c4fcaf6 to
d3067a0
Compare
goatgoose
reviewed
Aug 1, 2023
goatgoose
approved these changes
Aug 1, 2023
toidiu
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds memory benching with reusing configs between connections and releasing buffers. This PR also adds documentation of how to generate visualizations that have more details about memory usage.
Sample output/guis:
Testing:
To tell all possibilities of memory benching, running
bench-memory.sh.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.