Add different certificate signature algorithms to benchmarks #4080
Conversation
Co-authored-by: maddeleine <[email protected]>
bindings/rust/bench/src/lib.rs
Outdated
| CACert => "ca-cert.pem", | ||
| }; | ||
|
|
||
| let dir = match sig_type { |
There was a problem hiding this comment.
Would it make more sense to just implement Display for signature type?
There was a problem hiding this comment.
I think Display would be slightly misleading, since when you print (for example) CACert you would probably expect something like "CACert" or "root certificate", not the filename associated with the variant, which would be "ca-cert.pem" in this case.
There was a problem hiding this comment.
Ya, I was just thinking that CACert could display as ca-cert. Or more generally, the filename that corresponds to that particular enum should be information associated with the enum, rather than information associated with this helper function.
There was a problem hiding this comment.
It makes sense that PemType and SigType should own the information about themselves. Since the full path to a cert (ex. certs/ec384/server-key.pem) doesn't make sense to be owned by either one of them, I still want to keep the get_cert_path() function but just move the information about each enum to an impl for each enum (get_filename() for PemType and get_dir_name() for SigType).
| cert-gen ec 384 | ||
| cert-gen rsa 2048 | ||
| cert-gen rsa 3072 | ||
| cert-gen rsa 4096 | ||
|
|
There was a problem hiding this comment.
It might be time to add a clean function in this script that deletes all the generated pems. I'm thinking something like:
./generate_certs.sh clean
Do you think that would be useful? Otherwise the PR lgtm.
There was a problem hiding this comment.
I think it wouldn't hurt, and the control flow is fairly easy to understand; just added it.
commit eafb8a2 Author: Sam Clark <[email protected]> Date: Mon Jul 31 18:05:50 2023 -0400 shell -> bash commit 12071b8 Author: Sam Clark <[email protected]> Date: Mon Jul 31 17:59:09 2023 -0400 add ubuntu quickstart back to readme commit 10bf557 Author: Sam Clark <[email protected]> Date: Mon Jul 31 17:52:06 2023 -0400 fixes commit 74adf8d Author: Sam Clark <[email protected]> Date: Mon Jul 31 16:46:19 2023 -0400 fixes commit 0548d07 Author: Sam Clark <[email protected]> Date: Mon Jul 31 16:43:08 2023 -0400 consolidate commit cbe8f2d Author: Sam Clark <[email protected]> Date: Mon Jul 31 14:55:30 2023 -0400 remove old doc sections commit f194321 Author: Sam Clark <[email protected]> Date: Mon Jul 31 12:25:28 2023 -0400 more content commit 882eb1d Author: Sam Clark <[email protected]> Date: Mon Jul 31 09:08:24 2023 -0400 fixes commit ce37d0e Author: Sam Clark <[email protected]> Date: Mon Jul 31 09:03:45 2023 -0400 fixes commit 011d15f Author: Sam Clark <[email protected]> Date: Sat Jul 29 22:59:51 2023 -0400 cmake consuming commit 7feadc1 Author: Sam Clark <[email protected]> Date: Sat Jul 29 22:27:02 2023 -0400 fixes commit 2914950 Author: Sam Clark <[email protected]> Date: Sat Jul 29 21:34:24 2023 -0400 traditional make commit 02f9841 Author: Sam Clark <[email protected]> Date: Sat Jul 29 19:45:43 2023 -0400 s2n-tls build section commit 86c4983 Author: Sam Clark <[email protected]> Date: Sat Jul 29 11:56:32 2023 -0400 Update build documentation commit ea6d02a Author: Sam Clark <[email protected]> Date: Fri Jul 28 16:49:21 2023 -0400 bindings: release 0.0.35 (aws#4122) commit 35d08ba Author: Justin Zhang <[email protected]> Date: Fri Jul 28 12:31:21 2023 -0700 refactor(bench): separate out client and server connections in benching harness (aws#4113) Enables more better control of connections for benching experiments commit 65e74ca Author: Lindsay Stewart <[email protected]> Date: Wed Jul 26 02:26:40 2023 -0700 Print error for 32bit test (aws#4107) commit b0b253e Author: toidiu <[email protected]> Date: Wed Jul 26 00:30:44 2023 -0700 ktls: set keys on socket and enable ktls (aws#4071) commit 403d5e6 Author: Lindsay Stewart <[email protected]> Date: Tue Jul 25 16:03:09 2023 -0700 Trying to use an invalid ticket should not mutate state (aws#4110) commit bce2b1a Author: James Mayclin <[email protected]> Date: Tue Jul 25 14:44:33 2023 -0700 fix: get_session behavior for TLS 1.3 (aws#4104) commit 6881358 Author: Justin Zhang <[email protected]> Date: Tue Jul 25 10:10:21 2023 -0700 feat(bench): add different certificate signature algorithms to benchmarks (aws#4080) commit aab13d5 Author: Justin Zhang <[email protected]> Date: Mon Jul 24 18:17:30 2023 -0700 feat(bench): add memory bench with valgrind/massif (aws#4081) commit 20b0174 Author: Justin Zhang <[email protected]> Date: Mon Jul 24 13:26:32 2023 -0700 feat(bench): add historical performance benchmark (aws#4083) commit 5cc827d Author: Doug Chapman <[email protected]> Date: Thu Jul 20 11:50:50 2023 -0700 nix: pin corretto version (aws#4103)
Description of changes:
Add RSA2048, RSA4096, and EC384 certificates to benchmarks.
Testing:
Add certificate signature algorithms to existing handshake test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.