Add 32 bit buildspec #3977
Merged
Add 32 bit buildspec #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
approved these changes
May 4, 2023
maddeleine
reviewed
May 4, 2023
maddeleine
approved these changes
May 5, 2023
dougch
pushed a commit
to dougch/s2n-tls
that referenced
this pull request
May 31, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Makes progress on #3903
Description of changes:
This PR adds a build-spec for 32 bit cross-compiling builds. The docker image has already been updated to include 32 bit glibc and libcrypto dependencies, so after this is merged the final remaining step is to update the batch configuration in CodeBuild. This will be added to the "general batch" job, and the configuration will mirror that added in the omnibus configuration.
Call-outs:
This doesn't use the omniscript. This makes it easier for CodeBuild to surface errors and prevents more scripts from ending up in our codebuild directory. It also reduces the configuration that has to be passed in to the build spec.
This also doesn't prepend the
s2nidentifier to the32BitBuildAndUnitjob name. I don't think addings2nprovides any additional information, and there is precedent for this with thesawHMACPlusidentifier.Testing:
Draft: will be running this through the proposed batch change. Will update this section when that is done.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.