CI: Restrict Nix integ test to 1 job #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Mar 24, 2023
dougch
commented
Mar 27, 2023
harrisonkaiser
approved these changes
Mar 28, 2023
harrisonkaiser
approved these changes
Mar 29, 2023
lrstewart
approved these changes
Mar 29, 2023
dougch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
none
Description of changes:
For the Nix integ tests, we're running into port collision from (naively) spawning too many tests (see #2127 and related #3547). This renames the CMake flag
S2N_FAST_INTEG_TESTSand removes the logic to spawn too many test workers.Call-outs:
There were tabs in the cmake file that were removed (hence the messy diff)
The legacy integration tests could still be setup with CMake, without the S2N_INTEG_NIX flag.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally, CI
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.