Enforce that ENSURE and GUARD_OSSL use valid error codes #3873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I noticed that the same mistake made in #3853 (comment) has been made in several other places in the codebase. I corrected them all and added a check to grep_simple_mistakes.
To make the check work, I also had to correct S2N_RSA_PSS_NOT_SUPPORTED to S2N_ERR_RSA_PSS_NOT_SUPPORTED.
Testing:
This is the result if I intentionally re-introduce mistakes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.