[bindings] Generalize async in preparation for pkey offloading #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
binding_async
branch
from
a1aa9d2 to
2a5e152
Compare
lrstewart
commented
Feb 22, 2023
maddeleine
reviewed
Feb 22, 2023
maddeleine
approved these changes
Feb 23, 2023
camshaft
approved these changes
Feb 23, 2023
Comment on lines
+144
to
+153
| // pub(crate) fn trigger( | ||
| // future: ConnectionFutureResult, | ||
| // conn: &mut Connection, | ||
| //) -> CallbackResult { | ||
| // let future = OptionalFuture::new(future); | ||
| // let cleanup = MarkDone::None; | ||
| // let callback = AsyncCallback { future, cleanup }; | ||
| // conn.set_async_callback(callback); | ||
| // CallbackResult::Success | ||
| //} |
There was a problem hiding this comment.
I'm assuming this is going to be used for a later PR? I would say to probably include it there, if so
There was a problem hiding this comment.
I just saw that in your call outs. Not a big deal, then.
There was a problem hiding this comment.
Yeah I usually don't liked commented out code, but I'm un-commenting it in literally the next PR and without it it looks like this is still pretty client-hello specific ;) I just didn't want everyone calling trigger to have to pass in the MarkDone, even though only the ClientHello needs it.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous async logic was very ClientHello-specific. I've refactored so that only one struct has special casing for the ClientHello callback.
I initially didn't even have that special casing and was using Futures to handle the mark_client_hello_cb_done, but that seemed like overkill since more recent async callbacks can handle their own "mark_done". For example: pkey callbacks have s2n_async_pkey_op_apply(s2n_async_pkey_op*), psks have s2n_offered_psk_list_choose_psk(struct s2n_offered_psk_list *), early data has s2n_offered_early_data_accept(struct s2n_offered_early_data *). Basically, our usual model is that async callbacks have a specific instance of a callback-specific context, and the application calls a method on that context to set a result or indicate completion. We don't need to wait for the ConnectionFuture to complete.
Here's an example of one of the new callbacks implemented: lrstewart@0a1505a
Call-outs:
Testing:
Existing ClientHello callback tests pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.