Initialize blobs and stuffers #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This unintialized stuffer in s2n_quic_support_io_test.c caused our tests to fail in a particular build environment that doesn't automatically initialize stack variables.
This exact problem has bitten us a several times, so I did a simple find and replace that should have caught any uninitialized s2n_blob or s2n_stuffer structures. Fixing ALL unintialized variables is a much more challenging change (with a much larger diff). This is just better than fixing only the single instance that broke the build.
Call-outs:
Automating this in grep_simple_mistakes is probably doable, but tricky. I ran into a couple false positives with my simple search due to it being difficult to distinguish between stack variables and entries in a struct definition. An automated test would need to iterate over every line and keep "are we in a struct definition" state.
Testing:
Existing tests pass. I also verified this fixes the build issue I saw.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.