Ensure non-zero record protocol version #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Jan 5, 2023
harrisonkaiser
approved these changes
Jan 5, 2023
|
This is useful and helps reduce confusion for cases where the server needs to prematurely shut down the transport. thanks! Now clients should see this as an I/O or transport closure. Previously it looked like a protocol or implementation error due to "unknown protocol version" being spat out by TLS clients that didn't understand s2n server's close_notify. |
jmayclin
pushed a commit
to jmayclin/s2n-tls
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #1734
Description of changes:
I added a sane default protocol version to s2n_record_write_protocol_version. This covers any alert sent before the ClientHello is successfully parsed, not just close_notify.
Testing:
Added unit tests for s2n_record_write.c.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.