-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blob initialization fix-1 #3735
Conversation
c4cf15b
to
52ebedf
Compare
We probably want to add this it s2n-tls/codebuild/bin/grep_simple_mistakes.sh so we don't have regressions in the future. You can use a regex like this one to find instances that should be replaced: struct\s+s2n_blob\s+[a-zA-Z_][a-zA-Z0-9_]*\s*=\s*{\s*\.(data|size)\s*=\s*[^;]*,\s*\.(data|size)\s*=\s*[^;]*\s*}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your plans for addressing the rest of the un-initialized blobs? I see you say in the PR description you are going to put out more PRs for this issue, but it looks like your PR will resolve the initial issue keeping track of this.
I have a draft PR ready at the moment, should be able to wrap up in 2-3 more PR's. |
Resolved issues:
There are many blobs in s2n that have been created without using the s2n_init function and do not follow the new criteria.
This PR fixes that, and uses s2n_blob_init to initialize blobs.
Description of changes:
Initialization of blobs in s2n using the s2n_init function.
Call-outs:
Since there are many changes, I will have multiple PR's out for this issue.
Testing:
All tests pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.