Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-format tests/unit/s2n_s.*\.c and enforce in CI #3678

Merged
merged 20 commits into from
Dec 15, 2022

Conversation

harrisonkaiser
Copy link
Contributor

@harrisonkaiser harrisonkaiser commented Dec 2, 2022

Description of changes:

Clang-format tests/unit/s2n_s.*\.c and enforce in CI.

Call-outs:

Testing:

CI.

@harrisonkaiser harrisonkaiser marked this pull request as ready for review December 2, 2022 03:37
@github-actions github-actions bot added the s2n-core team label Dec 2, 2022
@harrisonkaiser harrisonkaiser changed the title Clang-format s and hand review + add to CI Clang-format tests/unit/s2n_s*.c and enforce in CI Dec 2, 2022
@harrisonkaiser harrisonkaiser changed the title Clang-format tests/unit/s2n_s*.c and enforce in CI Clang-format tests/unit/s2n_s.*\.c and enforce in CI Dec 2, 2022
@harrisonkaiser harrisonkaiser marked this pull request as draft December 2, 2022 04:22
@harrisonkaiser harrisonkaiser marked this pull request as ready for review December 8, 2022 22:16
@harrisonkaiser harrisonkaiser removed the request for review from maddeleine December 9, 2022 01:05
@harrisonkaiser harrisonkaiser enabled auto-merge (squash) December 14, 2022 17:58
@harrisonkaiser harrisonkaiser dismissed lrstewart’s stale review December 14, 2022 19:08

Changes made. Added clang-format off to tests/unit/s2n_safety_macros_test.c and re-generated

@harrisonkaiser
Copy link
Contributor Author

Looking for one more review @franklee26 or @lrstewart

@harrisonkaiser harrisonkaiser merged commit 6d8741c into aws:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants