Add compliance exceptions for server renegotiation #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add exceptions to the server renegotiation behavior for the compliance tool. Section 3.7 describes how the server needs to behave during renegotiation. We won't support client-initiated renegotiation and the s2n-tls server will never initiate renegotiation, so the server doesn't support renegotiation.
Call-outs:
I also renamed the other exceptions file. I originally accidentally called it "4.6" instead of "3.6". Apparently the compliance tool doesn't care about the file name :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.