-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create rfc9151 security policy #3431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! I would also suggest adding a note about this policy to the documentation
This looks like a good security policy, but SHA512 isn't included in CNSA (and therefore RFC 9151), so the name is misleading for the current implementation. We'll need to either remove SHA512 from this security policy or name it something different. |
Lets create a security policy for rfc9151 here. We can create a new one that includes sha512 if that is needed later. b7b81f1 |
7a9e1c8
to
b7b81f1
Compare
802fda3
to
3709637
Compare
&s2n_tls13_aes_256_gcm_sha384, | ||
}; | ||
|
||
const struct s2n_cipher_preferences cipher_preferences_rfc9151 = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, is there a reason why we are not using a date version string eg something like 20220822?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/aws/s2n-tls/blob/main/docs/USAGE-GUIDE.md
Numbered versions are fixed and will never change.
we try to avoid numbered version where possible since the numbers dont really mean much and since policy cant ever change, it will become outdated at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say we avoid them; they're all over. Outside of default, I think all of them are date-versioned. However, in this case I actually think the RFC number is a pretty reasonable version since RFCs are unable to change after being published. So we still have immutability and it actually means something as opposed to some arbitrary date.
8d13842
to
4c60acf
Compare
4fda4d8
to
fe60244
Compare
fe60244
to
7588a04
Compare
Description of changes:
Adds a new security policy with AES256, SHA384 and support for TLS1.3
Testing:
Verified that we can connect via tls1.3/tls1.2 and rsa/ecdsa
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.