Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup codecov artifacts #3425

Merged
merged 1 commit into from
Aug 3, 2022
Merged

cleanup codecov artifacts #3425

merged 1 commit into from
Aug 3, 2022

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Aug 3, 2022

We stopped uploading codecov reports awhile back. This PR attempts to cleanup the remaining bits.

Testing:

Existing CI should pass.

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu requested a review from dougch as a code owner August 3, 2022 00:08
@github-actions github-actions bot added the s2n-core team label Aug 3, 2022
@toidiu toidiu changed the title rm codecov cleanup codecov artifacts Aug 3, 2022
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor buildspec nit

@@ -50,5 +50,3 @@ phases:
post_build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally for all of these with nothing else happening in post_build, we could just drop the whole phase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes true. in the interest of not manually running the ci jobs again, i am inclined to address this in a follow up pr

Copy link
Contributor

@lrstewart lrstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you know that only codecov used gcov? And what uses lcov?

@toidiu
Copy link
Contributor Author

toidiu commented Aug 3, 2022

How do you know that only codecov used gcov?
if the integration tests pass then we should be ok

And what uses lcov?
seems like lcov is a graphical tool used for gcov reports. i can do a followup to remove that as well

@toidiu toidiu requested a review from lrstewart August 3, 2022 21:16
@toidiu toidiu enabled auto-merge (squash) August 3, 2022 21:51
@toidiu toidiu merged commit 7a13ba3 into aws:main Aug 3, 2022
@toidiu toidiu deleted the ak-rmCodecov branch August 3, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants