Add more testing for s2n_send #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a particular focus on the number of calls to send, how data is split between records, that the output buffer doesn't grow, and that all data is actually sent regardless of interruptions.
goatgoose
approved these changes
Jul 25, 2022
ghost
approved these changes
Jul 25, 2022
maddeleine
reviewed
Jul 25, 2022
maddeleine
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Expand the s2n_send unit tests in preparation to merge the buffered send work.
The new tests focus on the number of calls to send, how data is split between records, the size of the output stuffer (it can grow but should never grow), and that all data is eventually sent regardless of send failures.
Call-outs:
Any other cases you'd want covered before we make significant changes to the logic around buffering and sending records?
Testing:
This is all testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.