build(rust-bindings): use the 2021 rust edition #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
approved these changes
Jul 6, 2022
lrstewart
approved these changes
Jul 6, 2022
Comment on lines
124
to
+125
|
|
||
| if features.supports("features") { |
There was a problem hiding this comment.
This statement is ridiculous and I love it.
Comment on lines
+191
to
+193
|
|
||
| // link the built artifact | ||
| if lib.join("libs2n.a").exists() { |
There was a problem hiding this comment.
Why switch from checking for the .so to the .a? (see old line 186)
There was a problem hiding this comment.
I realized .so is only Linux. On macOS it's going to by .dylib. Whereas if we use .a we don't have to care :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change updates the rust bindings to use the 2021 edition of rust. This brings some new features as noted here.
The most applicable change here is the cargo resolver v2 is enabled by default. This fixes a few issues with feature resolution.
Call-outs:
The openssl-sys crate no longer seems to be consistently exporting the
DEP_OPENSSL_ROOTvariable. This causes some issues for the current cmake logic so I've removed it and only depend onDEP_OPENSSL_INCLUDE, which is still consistent.Testing:
The current CI checks should be sufficient to catch any issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.