Use CaDiCaL solver for s2n_stuffer_private_key_from_pem proof #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
approved these changes
May 13, 2022
lundinc2
pushed a commit
to lundinc2/s2n-tls
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A.
Description of changes:
There is currently a proof failure in CI. The proof is timing out after 6h. We use Kissat as back-end SAT solver for this all proofs, which takes too long to solve the resulting formula from the
s2n_stuffer_private_key_from_pemproof. This PR updates this proof to use CaDiCaL solver, which showed to be more efficient in this case.Call-outs:
N/A.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.