ci: Criterion benchmark handlers #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dougch
force-pushed
the
criterion_s2ncd_handler
branch
2 times, most recently
from
b115b59 to
1f142cd
Compare
camshaft
reviewed
May 21, 2022
| let s2nc_env: &str = &env::var("S2NC_ARGS").unwrap(); | ||
| let s2nc_args: utils::Arguments = s2nc_env.into(); | ||
| dbg!("s2nc harness: {:?}", &s2nc_args); | ||
| let output = Command::new("/usr/local/bin/s2nc") |
There was a problem hiding this comment.
This hard coded path means that s2nd/c need to be installed globally. May make this an environment variable?
There was a problem hiding this comment.
in my initial attempts at this, PATH was getting modified by tox/pytest, and it was easier to install these, since the default CMAKE_INSTALLPREFIX was left untouched in the path
dougch
force-pushed
the
criterion_s2ncd_handler
branch
2 times, most recently
from
75bf8cf to
f294e54
Compare
dougch
force-pushed
the
criterion_s2ncd_handler
branch
from
f294e54 to
668ac8c
Compare
toidiu
approved these changes
Aug 11, 2022
dougch
force-pushed
the
criterion_s2ncd_handler
branch
from
668ac8c to
89f1d34
Compare
dougch
force-pushed
the
criterion_s2ncd_handler
branch
from
77dcafe to
a24f115
Compare
WesleyRosenblum
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
part of #3130
Description of changes:
Changes to the Criterion benchmarks allow a criterion to call s2nc or s2nd.
part 4 of 5. This only affects integrationv2 tests when run with the
integrationv2critflag (once all are merged).Call-outs:
s2ncands2ndmust be in the path.Testing:
How is this change tested (unit tests, fuzz tests, etc.)? ci
Is this a refactor change? not exactly
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.