Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "extern" from function declarations in header files #1618

Closed
lrstewart opened this issue Mar 3, 2020 · 0 comments · Fixed by #3726
Closed

Remove "extern" from function declarations in header files #1618

lrstewart opened this issue Mar 3, 2020 · 0 comments · Fixed by #3726

Comments

@lrstewart
Copy link
Contributor

Problem:

Putting "extern" in front of a function declaration is redundant-- it's implied. We only want "extern" in places like variable declarations and api/s2n.h function declarations.

Unless I'm missing something and there's a valid reason we need explicit "extern"s in front of our function declarations?

Proposed Solution:

Short term: clean up header files to remove redundant "extern"s.
Long term: some sort of linter / add it to simple mistakes script
If we do need "extern": document why

lrstewart added a commit to lrstewart/s2n that referenced this issue May 19, 2020
- Add comments to magic number
- Add unnecessary "extern" for conformity. Someday, aws#1618.
@dougch dougch added the s2n-core team label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants