test(s2n-quic-dc): shared caches tests #2876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehnazyunus
commented
Oct 31, 2025
| let send_flags = MsgFlags::empty(); | ||
|
|
||
| sendmsg::<UnixAddr>( | ||
| sendmsg::<()>( |
Member
Author
There was a problem hiding this comment.
macos was complaining about send_to on a connected socket, hence this change.
mehnazyunus
commented
Oct 31, 2025
Mark-Simulacrum
approved these changes
Oct 31, 2025
boquan-fang
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Add tests for application crash, kernel queue full and dedup check.
Add
connectin uds sender without which the socket is always writable (kernel code). This avoids spinning on write to socket when the receive queue is full.Call-outs:
In the
test_kernel_queue_full_application_crash, verified that we see an error in the TCP worker on the manager server, and this code path is hit.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.