fix(s2n-quic-dc): support ipv6 control sockets #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
previously approved these changes
Oct 27, 2025
| fn send_control_packet(&self, dst: &SocketAddr, buffer: &mut [u8]) { | ||
| match self.control_socket.send_to(buffer, dst) { | ||
| let Some(control_socket) = self.control_socket.as_ref() else { | ||
| return; |
Collaborator
There was a problem hiding this comment.
It'd be good to wire this up to an event -- otherwise I suspect it'll be hard to debug why we're missing sends in production, should we fail to create the control socket for some reason. Probably also an event at map initialization time (bool field on the existing event?) noting that happened, with =1 being the negative state (failed to create) for easy alarming.
Contributor
Author
There was a problem hiding this comment.
It's a good call - though it'll need to be a follow-up change as I haven't had a ton of time :)
camshaft
force-pushed
the
camshaft/dc-control-socket
branch
from
8cecbfa to
6098b57
Compare
boquan-fang
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, the secret map control socket binds to an ipv4 address. This means that if a peer connects with ipv6 it's unable to receive secret control messages. This change fixes the control sockets to try binding to a ipv6 address before ipv4.
Testing:
I was able to verify this fixes issues with ipv6 deployments. That being said, we should probably add more ipv6 coverage in our tests. Unfortunately I don't have a ton of time to do that as part of this PR so it will have to come later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.