Skip to content

feat(s2n-quic-core) TLS offloading #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

feat(s2n-quic-core) TLS offloading #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b1dd6f
Initial commit
maddeleine Jun 26, 2025
0c9d359
Clippy lints
maddeleine Jul 1, 2025
99968fb
no-std fixes
maddeleine Jul 1, 2025
baabea9
Adds test
maddeleine Jul 3, 2025
06a2100
Remove std from core
maddeleine Jul 7, 2025
1bf7f1e
Clippy
maddeleine Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion quic/s2n-quic-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exclude = ["corpus.tar.gz"]
[features]
default = ["alloc", "std"]
alloc = ["atomic-waker", "bytes", "crossbeam-utils", "s2n-codec/alloc"]
std = ["alloc", "once_cell"]
std = ["alloc", "once_cell", "futures-channel", "futures"]
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondering if it would make more sense to have futures-channel and futures be part of the unstable-offload-tls feature in this crate. Since you don't really need those dependencies if you are only interested in using std and not the TLS offloading feature

testing = ["std", "generator", "s2n-codec/testing", "checked-counters", "insta", "futures-test"]
generator = ["bolero-generator"]
checked-counters = []
Expand Down Expand Up @@ -47,6 +47,8 @@ tracing = { version = "0.1", default-features = false, optional = true }
zerocopy = { version = "0.8", features = ["derive"] }
futures-test = { version = "0.3", optional = true } # For testing Waker interactions
once_cell = { version = "1", optional = true }
futures-channel = { version = "0.3", default-features = false, optional=true, features = ["std", "alloc"]}
futures = { version = "0.3", default-features = false, optional=true, features = ["std", "alloc"]}
Comment on lines +50 to +51
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there was an intention to have the dependencies be alphabetically ordered (through the last two in the list broke that). Could you move these and future-test and once_cell?

Copy link
Contributor

@camshaft camshaft Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also already have a channel in https://github.com/aws/s2n-quic/blob/main/quic/s2n-quic-core/src/sync/spsc.rs.


[dev-dependencies]
bolero = "0.13"
Expand Down
9 changes: 6 additions & 3 deletions quic/s2n-quic-core/src/crypto/tls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ pub mod null;
#[cfg(feature = "alloc")]
pub mod slow_tls;

#[cfg(feature = "std")]
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg(feature = "std")]
#[cfg(feature = "unstable-offload-tls")]

pub mod offload;

/// Holds all application parameters which are exchanged within the TLS handshake.
#[derive(Debug)]
pub struct ApplicationParameters<'a> {
Expand Down Expand Up @@ -177,13 +180,13 @@ pub trait Context<Crypto: crate::crypto::CryptoSuite> {
/// is willing to buffer.
fn receive_application(&mut self, max_len: Option<usize>) -> Option<Bytes>;

fn can_send_initial(&self) -> bool;
fn can_send_initial(&mut self) -> bool;
Copy link
Contributor

@camshaft camshaft Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically a breaking change if applications are implementing their own TLS providers.

fn send_initial(&mut self, transmission: Bytes);

fn can_send_handshake(&self) -> bool;
fn can_send_handshake(&mut self) -> bool;
fn send_handshake(&mut self, transmission: Bytes);

fn can_send_application(&self) -> bool;
fn can_send_application(&mut self) -> bool;
fn send_application(&mut self, transmission: Bytes);

fn waker(&self) -> &core::task::Waker;
Expand Down
Loading
Loading