fix(s2n-quic-core): optimize Bytes read on full read #2588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change optimizes a read to a Bytes/BytesMut when the watermark consumes the entire chunk. In this case, it doesn't matter if the caller optimizes on bytes or not - it's better to replace
selfwith an empty instance and return the chunk to potentially avoid copies.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.