feat(s2n-quic-tls, s2n-quic-rustls): emit server_name and application_protocol events sooner in the handshake #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 23, 2022
toidiu
changed the title
toidiu
commented
Mar 23, 2022
camshaft
reviewed
Mar 23, 2022
maddeleine
reviewed
Mar 23, 2022
maddeleine
reviewed
Mar 23, 2022
maddeleine
reviewed
Mar 23, 2022
This reverts commit 85b59d9.
camshaft
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently s2n-quic emits the
on_server_name_informationevent after it receives and installs the 1-rtt keys (and does a bunch of validation). This means that its possible to abort the handshake if any of the validation fails and not emit the server_name event.This makes it difficult for servers to debug which clients(server_name) is experiencing failures.
This PR moves the
on_server_name_informationevent to right after the server_name is parsed which solves the issue above.Similarly this PR also emits the
application_protocoland the associated event earlier.Callout:
Testing:
Existing test which complete the handshake should still pass. There is an inline assert which confirms that
on_server_namehappens prior to 1-rtt keys.Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.