Add up down arrow navigation in prompt field to access prompts in history #180
Conversation
…ntent from chat prompts
| @@ -311,6 +319,8 @@ export interface ChatPrompt { | |||
| escapedPrompt?: string; | |||
| command?: string; | |||
| context?: string[]; | |||
| attachmentContent?: string; | |||
| inputText?: string; | |||
There was a problem hiding this comment.
What is this in comparison to prompt?
There was a problem hiding this comment.
It is not so preferable to add these to typedef, if we're not planning to send it back to consumer. Since consumer uses this and they might expect to have an input text and attachment content. Instead, create a private interface extending from ChatPrompt for your use case
| @@ -245,6 +250,9 @@ export interface TreeNodeDetails { | |||
|
|
|||
| export interface ChatItemContent { | |||
| body?: string | null; | |||
| inputText?: string | null; | |||
There was a problem hiding this comment.
Just an idea; might be nice to bundle these 3 under something like inputs: {}
src/static.ts
Outdated
| /** | ||
| * The navigation index for the chat prompts list for the up/down arrow key navigation | ||
| */ | ||
| navigationIndexChatPrompts?: number; |
There was a problem hiding this comment.
Maybe change to upDownKeyNavigationIndex for consistency with UP_DOWN_ARROW_KEY_PRESS naming
There was a problem hiding this comment.
We should already have them in the keys list.
There was a problem hiding this comment.
We should already have them in the keys list.
sorry I didnt get this, not sure I know what is the key list and what you mean with 'them'?
| upDownArrowKeyPress?: ( | ||
| tabId: string, | ||
| direction: 'up' | 'down', | ||
| eventId?: string) => void; |
There was a problem hiding this comment.
huh? what is string), isn't there a parenthesis missing? (same for line 248)
There was a problem hiding this comment.
Not sure I got this. Maybe its just a formatting on github review? or a commit by commit review?
Here's what I see, I do not see any parenthesis missing 🙈
onFileActionClick?: (
tabId: string,
messageId: string,
filePath: string,
actionName: string,
eventId?: string) => void;
onTabBarButtonClick?: (
tabId: string,
buttonId: string,
eventId?: string) => void;
onUpDownArrowKeyPress?: (
tabId: string,
direction: 'up' | 'down',
eventId?: string) => void;
francescoopiccoli
deleted the
frapicc/up-down-arrow-prompt-navigation
branch
Problem
Up and down keys inside the prompt input field should switch between previous prompts like in a terminal. To increase the UX and let the end user easily access to a previous prompt to modify/improve it, the approach used in terminals needs to be applied.
Once I receive validation for my implementation approach I will proceed with adding tests and documentation.
Solution
Retrieving and identifying commands and code snippets from previous chat prompts, required adding some extra properties and methods that were not current available.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.