chore: eslint config to catch floating-promises #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodkevych
force-pushed
the
eslint-config-floating-promises
branch
from
c4444fe to
f9ab988
Compare
* chore(release): release packages from branch main * chore: trigger github actions for release please --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ege Ozcan <[email protected]>
volodkevych
force-pushed
the
eslint-config-floating-promises
branch
from
7718e0c to
8ef777b
Compare
Jurredr
approved these changes
Jan 17, 2025
natdurlik
reviewed
Jan 17, 2025
| rules: { | ||
| 'import/no-nodejs-modules': 'warn', | ||
| '@typescript-eslint/no-floating-promises': 'error', |
There was a problem hiding this comment.
Why not add these rules to the top-level .eslintrc.js for the entire monorepo?
There was a problem hiding this comment.
Because it will generate much more failures. I started with the project where we develop and the rest (requires more work) needs to be handled as part of different task that I created.
natdurlik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to the bug: #725
Solution
Enable
@typescript-eslint/no-floating-promisesto catch similar cases in the future.You can see, given the fix has not been merged yet, the build is failing: https://github.com/aws/language-servers/actions/runs/12808835517/job/35712403951?pr=728
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.