fix: convert makeProxyConfig to sync to allow proxy configs to be loa… #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natdurlik
reviewed
Jan 16, 2025
| @@ -140,7 +140,7 @@ export const makeProxyConfig = async (workspace: Workspace) => { | |||
| if (proxyUrl) { | |||
| const certs = isNodeJS | |||
| ? process.env.AWS_CA_BUNDLE | |||
| ? [await workspace.fs.readFile(process.env.AWS_CA_BUNDLE)] | |||
| ? [workspace.fs.readFileSync(process.env.AWS_CA_BUNDLE).toString()] | |||
There was a problem hiding this comment.
Do we need to have a separate method for synchronous file read? Have you tried solutions with using 'readFile' async in a factory create method instead of the constructor?
There was a problem hiding this comment.
I found this as a clean way to do it. Factory create instead of constructor is not required here and it would lead to a lot of refactoring, which might not be required.
pras0131
force-pushed
the
fixProxyIssueForInlineCompletion
branch
from
f451fd3 to
bce11f5
Compare
ege0zcan
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
volodkevych
pushed a commit
that referenced
this pull request
Jan 16, 2025
#725) * fix: convert makeProxyConfig to sync to allow proxy configs to be loaded before use * fix: remove toString() as return type changed to string now --------- Co-authored-by: Paras <[email protected]>
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert makeProxyConfig function to sync as to allow proxy configurations to be loaded before being used. There has been an issue where proxy was not working for inline completions as the configurations were being loaded asyncronously and when the client was setting the configs, they were not set. The change aims to fix the issue and it has been tested on local environment to be working fine using Charles proxy for inline completions.
[[ THE CHANGE IS DEPENDENT ON THIS PR https://github.com/aws/language-server-runtimes/pull/299/files]
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.