Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Helm Chart, Documentation, and Tests for Version Change #7441

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Updated Helm Chart, Documentation, and Tests for Version Change #7441

merged 3 commits into from
Nov 25, 2024

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Updated Helm Chart, Documentation, and Tests
How was this change tested?
make presubmit
make website
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner November 25, 2024 22:12
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 181c854
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6745095c6a54c40008160b90

@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12020726225

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 65.122%
Totals Coverage Status
Change from base Build 12019129855: 0.02%
Covered Lines: 5732
Relevant Lines: 8802
💛 - Coveralls

jmdeal
jmdeal previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

pkg/test/environment.go Show resolved Hide resolved
jmdeal
jmdeal approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 enabled auto-merge (squash) November 25, 2024 23:37
@edibble21 edibble21 merged commit 5a9af7c into aws:main Nov 25, 2024
17 checks passed
edibble21 added a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
@edibble21
Updated Helm Chart, Documentation, and Tests for Version Change (aws#…
5a62b94 
…7441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edibble21 @coveralls @jmdeal