-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Panic on kubelet compatibility annotation #7438
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 12035091403Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
a774527
to
49050b2
Compare
f2a8bfe
to
dbe020d
Compare
dbe020d
to
4086bfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hi @engedaam, Do we have a migration document regarding the kubelet configuration? To be honest, I couldn't locate it. |
It seems that removing this annotation is sufficient. Refer to: https://github.com/kubernetes-sigs/karpenter/blob/b1b45fc9218b30dd952959c5135867088e943c8b/designs/v1-api.md#migration-path |
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.