Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Panic on kubelet compatibility annotation #7438

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Panic when a nodepool kubelet has not been moved on to the v1 nodeclass kublete configuration

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner November 25, 2024 18:47
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4086bfe
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6745f9c2ca6f640007f714c5

@coveralls
Copy link

coveralls commented Nov 25, 2024

Pull Request Test Coverage Report for Build 12035091403

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 65.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 14 0.0%
Totals Coverage Status
Change from base Build 12034905593: -0.1%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5dc684c495cf62efb70d793761146f0c3ad22f85.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5dc684c495cf62efb70d793761146f0c3ad22f85" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/operator/operator.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the panic-on-kubelet-flag branch 2 times, most recently from a774527 to 49050b2 Compare November 26, 2024 14:59
pkg/operator/operator.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the panic-on-kubelet-flag branch 3 times, most recently from f2a8bfe to dbe020d Compare November 26, 2024 16:37
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 2fb10b6 into aws:main Nov 26, 2024
17 checks passed
@engedaam engedaam deleted the panic-on-kubelet-flag branch November 26, 2024 16:44
@weijiany
Copy link

weijiany commented Dec 2, 2024

Hi @engedaam, Do we have a migration document regarding the kubelet configuration? To be honest, I couldn't locate it.

@weijiany
Copy link

weijiany commented Dec 2, 2024

edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants