Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only support Ready Node Condition for Node Repair #7410

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Dropping support for DiskPressure and MemoryPressure

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner November 19, 2024 23:06
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 78a54b1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673d1a0819717500081b1cf8

@engedaam engedaam changed the title chore: Only support Ready Node Condition chore: Only support Ready Node Condition for Node Repair Nov 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11923383553

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.449%

Totals Coverage Status
Change from base Build 11917680940: 0.1%
Covered Lines: 5684
Relevant Lines: 6894

💛 - Coveralls

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engedaam engedaam merged commit bbb4996 into aws:main Nov 20, 2024
17 checks passed
@engedaam engedaam deleted the support-only-ready-node-condition branch November 20, 2024 00:08
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants