Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update error returned by cloudprovider.Create() #7385

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Update error returned by cloudprovider.Create() to use upstream CreateError.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner November 15, 2024 04:10
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b402b8b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6736f4299920bd00086f83b8

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11851895492

Details

  • 10 of 15 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 7 8 87.5%
pkg/providers/instance/instance.go 3 7 42.86%
Totals Coverage Status
Change from base Build 11834237756: 0.02%
Covered Lines: 5677
Relevant Lines: 6854

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit ea2254d into aws:main Nov 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants