Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Repair Policy cloud provider interface #7345

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 7, 2024

Fixes #N/A

Description

  • Implementation repair after policy with Kubelet node conditions
  • Current supported condition:
    • Ready
    • DiskPresure
    • MemoryPressure

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a7cdf60
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673c3ab7331ff400085d9899

@engedaam engedaam changed the title [WIP]feat: New Repair Policy CP interface [WIP]feat: Add Repair Policy CP interface Nov 7, 2024
@engedaam engedaam force-pushed the new-noderepair-helper branch 3 times, most recently from dce5ee2 to 9f86be4 Compare November 13, 2024 16:27
@engedaam engedaam force-pushed the new-noderepair-helper branch 4 times, most recently from 8c73463 to 289aa4b Compare November 16, 2024 23:24
@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 11908025003

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 82.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/fake/cloudprovider.go 0 3 0.0%
pkg/cloudprovider/cloudprovider.go 0 20 0.0%
Totals Coverage Status
Change from base Build 11899442406: -0.3%
Covered Lines: 5684
Relevant Lines: 6904

💛 - Coveralls

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-289aa4bcab3bcf1f4e639f4cdf68e7f1bda4dfe4.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-289aa4bcab3bcf1f4e639f4cdf68e7f1bda4dfe4" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam force-pushed the new-noderepair-helper branch 2 times, most recently from cab07d5 to 493d3eb Compare November 17, 2024 03:39
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-493d3eb0de0cc94f48c77d32573aa63e420fc883.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-493d3eb0de0cc94f48c77d32573aa63e420fc883" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam force-pushed the new-noderepair-helper branch 4 times, most recently from 3b30caf to 5605a7c Compare November 18, 2024 01:54
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5605a7c6e83fb872f80762bd7f0b6016b3561d47.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5605a7c6e83fb872f80762bd7f0b6016b3561d47" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@engedaam engedaam changed the title [WIP]feat: Add Repair Policy CP interface feat: Add Repair Policy cloud provider interface Nov 18, 2024
@engedaam engedaam force-pushed the new-noderepair-helper branch 2 times, most recently from 3c00b04 to 346ffcb Compare November 18, 2024 05:56
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpetner snapshot

@engedaam engedaam marked this pull request as ready for review November 18, 2024 05:56
@engedaam engedaam requested a review from a team as a code owner November 18, 2024 05:56
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-346ffcb6bd821aa26cb7abb88776af09b4887c00.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-346ffcb6bd821aa26cb7abb88776af09b4887c00" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis
jonathan-innis previously approved these changes Nov 19, 2024
test/suites/integration/repair_policy_test.go Outdated Show resolved Hide resolved
test/suites/integration/repair_policy_test.go Outdated Show resolved Hide resolved
test/suites/integration/repair_policy_test.go Outdated Show resolved Hide resolved
test/suites/integration/repair_policy_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 469ef7f into aws:main Nov 19, 2024
17 checks passed
@engedaam engedaam deleted the new-noderepair-helper branch November 19, 2024 07:21
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants