You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description
Reverting this since we should enforce an invariant that the cloud provider returns a real instance type. This prevents the CP from implementing a fix to return a nil instance type if an instance type shouldn't be used. We should opt to just mark all of the offerings as unavailable. But still allow it to be discovered. This allows us to not provision nodes that have this instance type, but still allow us to drift it if it no longer appears in describeinstancetypes
How was this change tested?
Does this change impact docs?
Yes, PR includes docs updates
Yes, issue opened: #
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e07b37d.
Fixes #N/A
Description
Reverting this since we should enforce an invariant that the cloud provider returns a real instance type. This prevents the CP from implementing a fix to return a nil instance type if an instance type shouldn't be used. We should opt to just mark all of the offerings as unavailable. But still allow it to be discovered. This allows us to not provision nodes that have this instance type, but still allow us to drift it if it no longer appears in describeinstancetypes
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.