Chore: EC2 and EKS migration v2 #7198

edibble21 · 2024-10-11T00:18:32Z

Fixes #N/A

Description
EC2 and EKS migration v2
How was this change tested?
make test
Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-10-11T00:18:46Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`e9c9a88`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/672bc7994ff07b0008a86ada

edibble21

/Karpenter snapshot

github-actions · 2024-10-11T03:01:15Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-90132252c7007355bce31c2e2b71b2ba3ca6cd32.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-90132252c7007355bce31c2e2b71b2ba3ca6cd32" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

edibble21

/Karpenter snapshot

coveralls · 2024-10-11T18:15:09Z

Pull Request Test Coverage Report for Build 11710771059

Details

615 of 724 (84.94%) changed or added relevant lines in 35 files are covered.
17 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.2%) to 82.848%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/batcher/createfleet.go	8	9	88.89%
pkg/cloudprovider/cloudprovider.go	2	3	66.67%
pkg/controllers/controllers.go	0	1	0.0%
pkg/fake/pricingapi.go	9	10	90.0%
pkg/providers/instanceprofile/instanceprofile.go	2	3	66.67%
pkg/providers/subnet/subnet.go	26	27	96.3%
pkg/fake/utils.go	38	40	95.0%
pkg/providers/instance/types.go	18	20	90.0%
pkg/errors/errors.go	5	8	62.5%
pkg/providers/amifamily/resolver.go	1	4	25.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/fake/ec2api.go	1	87.64%
pkg/providers/instancetype/types.go	1	96.63%
pkg/providers/instance/instance.go	1	89.15%
pkg/providers/pricing/pricing.go	1	88.62%
pkg/providers/instance/types.go	1	90.0%
pkg/operator/operator.go	4	9.8%
pkg/providers/launchtemplate/launchtemplate.go	8	78.45%

Totals
Change from base Build 11695486973:	0.2%
Covered Lines:	5685
Relevant Lines:	6862

💛 - Coveralls

edibble21

/Karpenter snapshot

github-actions · 2024-10-11T18:18:38Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-eea07e75a83f537a2899043919566a16ede640bd.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-eea07e75a83f537a2899043919566a16ede640bd" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

…ed (aws#7213)

…actions-deps group (aws#7208) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ns/install-deps in the action-deps group (aws#7201) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…tions/e2e/setup-cluster in the action-deps group (aws#7207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

edibble21

/Karpenter snapshot

github-actions · 2024-10-15T17:34:39Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-7c8cd8ae2996f5a572b38eef2a0276c1459550d4.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-7c8cd8ae2996f5a572b38eef2a0276c1459550d4" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

hack/code/bandwidth_gen/main.go

hack/code/instancetype_testdata_gen/main.go

pkg/batcher/createfleet_test.go

pkg/providers/pricing/pricing.go

pkg/providers/subnet/subnet.go

edibble21

/karpenter snapshot

github-actions · 2024-11-04T21:05:18Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5134c2255988cd859f5706ae8c100c1d7f83ed9f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5134c2255988cd859f5706ae8c100c1d7f83ed9f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/errors/errors.go

pkg/fake/utils.go

pkg/operator/operator.go

go.mod

pkg/providers/pricing/zz_generated.pricing_aws.go

pkg/providers/pricing/pricing.go

pkg/providers/pricing/zz_generated.pricing_aws_cn.go

pkg/providers/pricing/zz_generated.pricing_aws_us_gov.go

pkg/providers/pricing/pricing.go

pkg/operator/operator.go

test/suites/termination/termination_test.go

test/suites/nodeclaim/nodeclaim_test.go

test/suites/nodeclaim/garbage_collection_test.go

test/pkg/environment/aws/environment.go

test/pkg/environment/aws/expectations.go

test/suites/integration/aws_metadata_test.go

test/suites/nodeclaim/nodeclaim_test.go

jonathan-innis

LGTM 🚀

jonathan-innis

LGTM 🚀

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Amanuel Engeda <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

edibble21 added 3 commits October 10, 2024 14:11

EC2API migration

83ea515

Migrated launchtemplate_counter

c0f71ef

fixing linter issues

9013225

edibble21 commented Oct 11, 2024

View reviewed changes

fixed client connectivity check

eea07e7

edibble21 commented Oct 11, 2024

View reviewed changes

engedaam self-assigned this Oct 14, 2024

edibble21 force-pushed the EC2MigrationV2 branch 2 times, most recently from d3767f1 to eea07e7 Compare October 14, 2024 23:25

njtran and others added 11 commits October 14, 2024 17:24

docs: clarify do-not-consolidate/do-not-evict was replaced, not remov…

c8a4cba

…ed (aws#7213)

test: Add e2e testing for deprecated AMIs (aws#6990)

9b8c87f

chore(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3 in the …

1749533

…actions-deps group (aws#7208) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump actions/cache from 4.1.0 to 4.1.1 in /.github/actio…

3012c72

…ns/install-deps in the action-deps group (aws#7201) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: Migrated ssm, sts, fis, and sqs to v2 (aws#7197)

7225b43

EC2API migration

57fb8ca

Migrated launchtemplate_counter

1aca482

Fix dependency issues

055fa0f

Merge branch 'main' into EC2MigrationV2

94cc9be

ci test fix

7c8cd8a

edibble21 force-pushed the EC2MigrationV2 branch from ed03436 to 7c8cd8a Compare October 15, 2024 17:23

edibble21 commented Oct 15, 2024

View reviewed changes

edibble21 added 2 commits October 15, 2024 17:13

fix before each issue

364894b

Merge branch 'main' into EC2MigrationV2

1a95784

edibble21 added 3 commits October 28, 2024 21:00

Merge branch 'main' into EC2MigrationV2

03d7f22

fixed ci-test

e734605

Merge branch 'main' into EC2MigrationV2

ef0edf4

jonathan-innis reviewed Oct 30, 2024

View reviewed changes

edibble21 added 7 commits October 31, 2024 15:44

Adressed New Feedback

b7746d9

Merge branch 'main' into EC2MigrationV2

e1894a0

fix presubmit

c7cfda1

Merge branch 'main' into EC2MigrationV2

de7e1c5

Merge branch 'main' into EC2MigrationV2

23a55e6

Merge branch 'main' into EC2MigrationV2

11896da

Addressed feedback

5134c22

edibble21 commented Nov 4, 2024

View reviewed changes

edibble21 added 3 commits November 4, 2024 16:36

Merge branch 'main' into EC2MigrationV2

0d43d99

Fix Error Code

df89470

fix presubmit

19eca8a

jonathan-innis reviewed Nov 5, 2024

View reviewed changes

latest feedback changes

6d93d89

jonathan-innis reviewed Nov 6, 2024

View reviewed changes

pkg/providers/pricing/pricing.go Outdated Show resolved Hide resolved

pkg/operator/operator.go Outdated Show resolved Hide resolved

jonathan-innis reviewed Nov 6, 2024

View reviewed changes

edibble21 added 2 commits November 6, 2024 10:31

Merge branch 'main' into EC2MigrationV2

321b04c

feedback changes

0dc890a

jonathan-innis reviewed Nov 6, 2024

View reviewed changes

test/suites/nodeclaim/nodeclaim_test.go Outdated Show resolved Hide resolved

jonathan-innis previously approved these changes Nov 6, 2024

View reviewed changes

fixed nit

e9c9a88

edibble21 dismissed jonathan-innis’s stale review via e9c9a88 November 6, 2024 19:46

jonathan-innis approved these changes Nov 6, 2024

View reviewed changes

edibble21 merged commit 655d473 into aws:main Nov 6, 2024
17 checks passed

edibble21 deleted the EC2MigrationV2 branch November 6, 2024 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: EC2 and EKS migration v2 #7198

Chore: EC2 and EKS migration v2 #7198

edibble21 commented Oct 11, 2024

netlify bot commented Oct 11, 2024 •

edited

Loading

edibble21 left a comment

github-actions bot commented Oct 11, 2024

edibble21 left a comment

coveralls commented Oct 11, 2024 •

edited

Loading

edibble21 left a comment

github-actions bot commented Oct 11, 2024

edibble21 left a comment

github-actions bot commented Oct 15, 2024

edibble21 left a comment

github-actions bot commented Nov 4, 2024

jonathan-innis left a comment

jonathan-innis left a comment

Chore: EC2 and EKS migration v2 #7198

Chore: EC2 and EKS migration v2 #7198

Conversation

edibble21 commented Oct 11, 2024

netlify bot commented Oct 11, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

edibble21 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2024

edibble21 left a comment

Choose a reason for hiding this comment

coveralls commented Oct 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11710771059

Details

💛 - Coveralls

edibble21 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2024

edibble21 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2024

edibble21 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

netlify bot commented Oct 11, 2024 •

edited

Loading

coveralls commented Oct 11, 2024 •

edited

Loading