Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gomod to bring in ignore terminating nodes in budgets #7154

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: update gomod to bring in ignore terminating nodes in budgets #7154

merged 1 commit into from
Oct 3, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 3, 2024

Fixes #N/A

Description
Pulls in kubernetes-sigs/karpenter#1735

How was this change tested?
locally and presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 3, 2024 21:11
@njtran njtran requested a review from tzneal October 3, 2024 21:11
@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1d69bd2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ff089c0434c600082c73e0

@njtran njtran enabled auto-merge (squash) October 3, 2024 21:13
jonathan-innis
jonathan-innis approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11169805128

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.303%
Totals Coverage Status
Change from base Build 11146769679: 0.0%
Covered Lines: 5573
Relevant Lines: 6690
💛 - Coveralls

@njtran njtran merged commit 31f3d18 into aws:main Oct 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @jonathan-innis