Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: implementing observability around usage of deprecated amis #7145

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

shabbskagalwala
Copy link
Contributor

Fixes #N/A

Description

This is an RFC for implementing observability around usage of deprecated AMIs that was implemented with #6500

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b549ad4
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/672979eaa6e49300080c64be

@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11676043862

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.679%

Totals Coverage Status
Change from base Build 11674802395: 0.0%
Covered Lines: 5704
Relevant Lines: 6899

💛 - Coveralls

@engedaam engedaam self-assigned this Oct 2, 2024
@engedaam
Copy link
Contributor

engedaam commented Oct 9, 2024

@shabbskagalwala Any updates here?

@shabbskagalwala shabbskagalwala force-pushed the rfc-deprecated-ami-observability branch 3 times, most recently from 1b5abcd to a72d677 Compare October 11, 2024 16:10
@shabbskagalwala
Copy link
Contributor Author

@engedaam apologies for the ping but any update on this?

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

designs/deprecated-ami-observability.md Outdated Show resolved Hide resolved
designs/deprecated-ami-observability.md Outdated Show resolved Hide resolved
designs/deprecated-ami-observability.md Outdated Show resolved Hide resolved
designs/deprecated-ami-observability.md Show resolved Hide resolved
designs/deprecated-ami-observability.md Show resolved Hide resolved
designs/deprecated-ami-observability.md Show resolved Hide resolved
designs/deprecated-ami-observability.md Show resolved Hide resolved
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 30d03a5 into aws:main Nov 5, 2024
16 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants