-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc: implementing observability around usage of deprecated amis #7145
Merged
engedaam
merged 4 commits into
aws:main
from
shabbskagalwala:rfc-deprecated-ami-observability
Nov 5, 2024
Merged
rfc: implementing observability around usage of deprecated amis #7145
engedaam
merged 4 commits into
aws:main
from
shabbskagalwala:rfc-deprecated-ami-observability
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
engedaam
reviewed
Oct 2, 2024
Pull Request Test Coverage Report for Build 11676043862Details
💛 - Coveralls |
@shabbskagalwala Any updates here? |
shabbskagalwala
force-pushed
the
rfc-deprecated-ami-observability
branch
3 times, most recently
from
October 11, 2024 16:10
1b5abcd
to
a72d677
Compare
@engedaam apologies for the ping but any update on this? |
engedaam
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
shabbskagalwala
force-pushed
the
rfc-deprecated-ami-observability
branch
from
October 28, 2024 21:34
e115bda
to
4d9ba7c
Compare
shabbskagalwala
force-pushed
the
rfc-deprecated-ami-observability
branch
from
October 28, 2024 21:39
4d9ba7c
to
5bf52f3
Compare
engedaam
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
edibble21
pushed a commit
to edibble21/karpenter-provider-aws
that referenced
this pull request
Nov 11, 2024
…7145) Co-authored-by: skagalwala <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This is an RFC for implementing observability around usage of deprecated AMIs that was implemented with #6500
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.