Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove prefix from chart.appversion in helpers.tpl #7135

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore: Remove prefix from chart.appversion in helpers.tpl #7135

merged 1 commit into from
Oct 1, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #7084

Description
Dropping prefix v from tag from helpers.tpl

How was this change tested?
manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner October 1, 2024 16:44
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 04cc2f3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fc270609c7a20008019bc7

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11129772826

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 83.291%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11114036513: -0.03%
Covered Lines: 5578
Relevant Lines: 6697
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit a857eb2 into aws:main Oct 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@rschalo rschalo Awaiting requested review from rschalo rschalo is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default value for karpenter.controller.image template in _helper.tpl incorrectly prefixes version with a v
3 participants
@jigisha620 @coveralls @jonathan-innis