Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove InstanceTypeProvider dependency from Instance Provider #7067

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Remove InstanceTypeProvider dead dependency in Instance Provider

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b41cf6e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f48eee5e070400074b1347

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11042110981

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 83.121%

Totals Coverage Status
Change from base Build 11041530198: 0.04%
Covered Lines: 5550
Relevant Lines: 6677

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit abd43f3 into aws:main Sep 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants