Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add an amifamily.Resolver interface #7064

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Add a missed interface for amifamily.Resolver

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 25, 2024 02:57
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 25, 2024 02:58
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0ec0805
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f37c373e62f20008456ba1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11025476957

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 83.005%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11024026989: -0.04%
Covered Lines: 5519
Relevant Lines: 6649

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit dde5589 into aws:main Sep 25, 2024
16 checks passed
@jonathan-innis jonathan-innis deleted the amifamily-resolver-iface branch September 25, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants