Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add launch template test expectations from #7020 #7055

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 23, 2024

Fixes #N/A

Description

Add launch template test expectations from #7020

Thanks to @jigisha620 and @jmdeal for tracking down this same issue that was plaguing release-v1.0.x in main

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c063931
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f35543694cca0008e3b740

@jonathan-innis jonathan-innis force-pushed the add-launch-template-expectations branch 4 times, most recently from af904c7 to a3e1a97 Compare September 25, 2024 00:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11023864798

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.995%

Totals Coverage Status
Change from base Build 10998326235: 0.0%
Covered Lines: 5520
Relevant Lines: 6651

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-c063931072bde5dc61b67ed71ab6c2ca61ae55a2.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-c063931072bde5dc61b67ed71ab6c2ca61ae55a2" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis merged commit d3b06cc into aws:main Sep 25, 2024
19 of 33 checks passed
@jonathan-innis jonathan-innis deleted the add-launch-template-expectations branch September 25, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants